Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloning only target branch with depth 1 #16

Merged
merged 5 commits into from
Mar 1, 2024
Merged

cloning only target branch with depth 1 #16

merged 5 commits into from
Mar 1, 2024

Conversation

tahiat
Copy link
Owner

@tahiat tahiat commented Mar 1, 2024

Professor, This PR clones a target repository with no additional commit history (depth 1). However, some target information requires a commit that is deep in the commit history. I am thinking of forking that repository and creating a branch targeting that commit. That way we do the depth 1 clone. This will require some changes in the JSON data (url and branch name). Do you suggest that I do that?

@tahiat tahiat requested a review from kelloggm March 1, 2024 18:34
@kelloggm
Copy link
Collaborator

kelloggm commented Mar 1, 2024

I am thinking of forking that repository and creating a branch targeting that commit. That way we do the depth 1 clone. This will require some changes in the JSON data (url and branch name). Do you suggest that I do that?

Yes. I'll wait to review this until you do.

@tahiat tahiat requested review from kelloggm and removed request for kelloggm March 1, 2024 20:26
Copy link
Collaborator

@kelloggm kelloggm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@kelloggm kelloggm merged commit e94e18a into main Mar 1, 2024
1 check passed
@kelloggm kelloggm deleted the optimization branch March 1, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants